From 60e1c357458b78c2a208c181d63aa766995b4d3b Mon Sep 17 00:00:00 2001
From: Florez Ospina Juan Felipe <juan.florez-ospina@psi.ch>
Date: Thu, 20 Feb 2025 17:26:50 +0100
Subject: [PATCH] Move flag definitions from ...utils.py to
 flags/ebas_flags.yaml

---
 app/data_flagging_utils.py | 21 +++++----------------
 app/flags/ebas_dict.yaml   | 37 +++++++++++++++++++++++++++++++++++++
 2 files changed, 42 insertions(+), 16 deletions(-)
 create mode 100644 app/flags/ebas_dict.yaml

diff --git a/app/data_flagging_utils.py b/app/data_flagging_utils.py
index 302112a..ce414c5 100644
--- a/app/data_flagging_utils.py
+++ b/app/data_flagging_utils.py
@@ -11,20 +11,9 @@ import dima.utils.g5505_utils as utils
 
 UPLOAD_DIRECTORY = 'data/'
 
-flags_dict = {
-        "000" : {"flag_label": 'V', "flag_description": "Valid measurement"},
-        "100" : {"flag_label": 'V', "flag_description": "Checked by data originator. Valid measurement, overrides any invalid flags"},
-        "110" : {"flag_label": 'V', "flag_description": "Episode data checked and accepted by data originator. Valid measurement"},
-        "111" : {"flag_label": 'V', "flag_description": "Irregular data checked and accepted by data originator. Valid measurement"},
-        "456" : {"flag_label": 'I', "flag_description": "Invalidated by data originator"},
-        "460" : {"flag_label": 'I', "flag_description": "Contamination suspected"},
-        "559" : {"flag_label": 'V', "flag_description": "Unspecified contamination or local influence, but considered valid"},
-        "599" : {"flag_label": 'I', "flag_description": "Unspecified contamination or local influence"},
-        "652" : {"flag_label": 'V', "flag_description": "construction/activity nearby"},
-        "659" : {"flag_label": 'I', "flag_description": "Unspecified instrument/sampling anomaly"},
-        "660" : {"flag_label": 'V', "flag_description": "Unspecified instrument/sampling anomaly"},
-        "999" : {"flag_label": 'I', "flag_description": "Missing measurement, unspecified reason"}
-        }
+
+
+
 
 def save_file(name, content):
     # Decode the content and save the file
@@ -53,8 +42,8 @@ def filter_flags_by_label(flags_dict, label):
     --------
         list: A list of dictionaries with 'label' and 'value' for the specified label.
     """
-    return [{'label': value['flag_description'], 'value': code} 
-            for code, value in flags_dict.items() if value['flag_label'] == label]
+    return [{'label': value['description'], 'value': code} 
+            for code, value in flags_dict.items() if value['validity'] == label]
 
 
 def create_loaded_file_figure(file_path, instFolder, dataset_name, datetime_var, datetime_var_format, variables):
diff --git a/app/flags/ebas_dict.yaml b/app/flags/ebas_dict.yaml
new file mode 100644
index 0000000..418e74d
--- /dev/null
+++ b/app/flags/ebas_dict.yaml
@@ -0,0 +1,37 @@
+flags:
+  0:
+    validity: "V"
+    description: "Valid measurement"
+  100:
+    validity: "V"
+    description: "Checked by data originator. Valid measurement, overrides any invalid flags"
+  110:
+    validity: "V"
+    description: "Episode data checked and accepted by data originator. Valid measurement"
+  111:
+    validity: "V"
+    description: "Irregular data checked and accepted by data originator. Valid measurement"
+  456:
+    validity: "I"
+    description: "Invalidated by data originator"
+  460:
+    validity: "I"
+    description: "Contamination suspected"
+  559:
+    validity: "V"
+    description: "Unspecified contamination or local influence, but considered valid"
+  599:
+    validity: "I"
+    description: "Unspecified contamination or local influence"
+  652:
+    validity: "V"
+    description: "Construction/activity nearby"
+  659:
+    validity: "I"
+    description: "Unspecified instrument/sampling anomaly"
+  660:
+    validity: "V"
+    description: "Unspecified instrument/sampling anomaly"
+  999:
+    validity: "I"
+    description: "Missing measurement, unspecified reason"